User talk:Ickputzdirwech

Jump to navigation Jump to search

About this board

Not editable

Harakoni (talkcontribs)

Just dropping by to say thank you yet again for everything you do in maintaining the wiki. Edits, templates, linkfixes, categorizations all the other stuff needed to keep the wiki going for both readers and other editors. This'd all be a hell of a lot harder without your help.

Ickputzdirwech (talkcontribs)

Thanks for your kind words! It’s a pleasure :)

I really like how you utilised the DLC Icons template btw. I would have never thought of that.

Harakoni (talkcontribs)

Each pawn uses a body of a set type that defines all their body parts and the parts' base health. Some animals share body types - for example a Cat and a Cougar both use QuadrupedAnimalWithPawsAndTail, but obviously it doesn't make sense for the cat to be just as durable as the cougar. Health Scale acts as a multiplier for the HP of every body part.

So a Cat has a health scale of 0.42 and a cougar has a health scale of 1.3, so the tail of a cat will have 32% the hit points of a cougar tail.

Ickputzdirwech (talkcontribs)

Thanks for the explanation!

Harakoni (talkcontribs)

The various meals have recreation offsets defined in their infoboxes. Just wondering if you know anything about them, because I can't see any effect in game nor can I find any evidence for them in the .xmls. Looks like they were there back before you did your legendary slog converting all the defines to infoboxes so its probably just a left over from an old version?

I'm going to take them out, but please let me know if theres something I'm missing and they're still valid.

Ickputzdirwech (talkcontribs)

I'm pretty sure you are right. I can't find them anywhere either. Is it possible that these values got replaced by the thoughts "ate lavish meal" etc.?

Summary by Harakoni

Obsoleted rather than deleted

Harakoni (talkcontribs)
Ickputzdirwech (talkcontribs)

Short answer: I don't know if they were ever in use.

Harakoni (talkcontribs)

No worries, I'll look into it myself before deletion

Summary by Ickputzdirwech

defName should be used consistently.

Harakoni (talkcontribs)

Why is defName now defined in two different ways in the infobox template?

Ickputzdirwech (talkcontribs)

There is no good reason for it, other than that I didn’t change the parameter on a lot of pages when I switched from define and I thought instead of changing all pages individually I could fix it via the template. Apart from being a dumb idea it also doesn’t work as it’s supposed to. Forgot to clean it up again.

Harakoni (talkcontribs)

There are ways to implement that (e.g. checking for one and only if it doesn't exist, looking for the other, and having both assign to the same property) but its not best practice and can still cause issues down the line. Glad you fixed it.

If the issue identifying the pages to be fixed though, you can make a temporary edit to the template looking for the wrong one, and assign pages with it to a category or set some test property, and then use that to find them. Then just revert the edit to the template once you're done. Should make it pretty easy to fix it in bulk.

But I;m sure you'd have worked that out yourself, if you hadn't already - lemme know if you have any issues and feel free to close this topic if you don't have anything else to add.

Ickputzdirwech (talkcontribs)

Fixed the pages I remember making the changeover from define to infobox main recently. I will check again when the changeover is finished.

Summary by Ickputzdirwech

Added a third parameter "delta" on Template:Temperature and checked all recent revisions.

Harakoni (talkcontribs)

Be careful using the Temperature template. The template convert it assuming that it is the actual temperature of a thing but some of the places you've used are actually the relative difference in temperature.

So for example, if the temperature of something IS 30C then it is also 86F (i.e. {{Temperature|30}} = 30 °C (86 °F)), but if something is 30C HOTTER than another thing, then it is 54F hotter than the other thing not 86F hotter than that thing (e.g. 30 °C (86 °F) vs 0 °C (32 °F))

I am very tired so that might not make sense. Let me know if I'm was unclear.

Harakoni (talkcontribs)

My god there was like 10 different spelling and grammar mistakes in that alone. I think I'll leave you to fix it rather than try it myself in this state. If I'm reading it correctly, Apparel, Insect Jelly, Mood and maybe the infobox template have this issue. Might be an idea to check them all though JIC.

Ickputzdirwech (talkcontribs)

Facepalm :( Thanks for the message! I‘ll fix it asap

Harakoni (talkcontribs)
Harakoni (talkcontribs)

First, I am so impressed with all of your work to convert the define templates to infoboxes. Its a huge process and its been needed for so long, so it is massively appreciated.

Second, with Property:Product Amount have you thought about how to handle kibble which apparently produces different amounts from the same recipe depending on where it is made? (I haven't actually checked that that it is still true, so it may be a non-issue)

Third, so you've added Cooking as the skill for Wort, but without a level because anyone can do it. Previously its only been set on things with a requirement. I'm not saying its wrong or anything but I would be interested in your input on how best to display stuff as you're probably the only current user besides me with experience with the infobox template. To me there seems to be several pieces of relevant info:

  • Skill requirement
  • Skill that gets XP from performing the task
  • Skill that controls quality
  • Stat that controls crafting speed
  • Work type that allows the bill to be processed/will be banned by traits and backstories

Not everything has a skill requirement (e.g. wort), not everything gives XP (stone blocks), not everything has quality (e.g. clubs which are otherwise a normal crafting), theres a bunch of different crafting speed stats and some items have skills control their production speed, others don't (e.g. Construction vs Tailoring) others conflict with the other categories (e.g. smokeleaf uses the cooking stat for its speed, but is done with often done with the intellectual work type).

There is some overlap with these, and some might be completely redundant with another. I haven't gone looking for all the edge cases yet. But overall its a convoluted mess to display. I think I want to have at least Skill Required and Crafting Speed Stat, but not 100%. I'd appreciate your input on it

Ickputzdirwech (talkcontribs)

1. Thanks!

2. I just had a quick look at the game files and the product amount of the kibble recipe is 50. The butcher spot however has the property "WorkTableEfficiencyFactor" of 0.7. So I think on the kibble page Product Amount should just be 50.

3. The way I thought about it so far was that the infobox should show which skill is required to execute the task. For wort there is no level required, but a pawn incapable of cooking won't be able to make it. But as you said I'll have to look at some edge cases first.

4. Allow me to add that some parts of the infobox and some properties are quite a mess right now. But it's a huge task changing anything about it, which is why so far I just added new stuff, afraid of breaking anything important. Is there a way seeing which pages actually use a property? Like a "What links here"-page? This would allow us to see which properties are just garbage that can be removed.

Harakoni (talkcontribs)

Saw the new redlink pop up on the special pages. The name was improperly defined in the infobox on Large stele. Should be fixed now

Ickputzdirwech (talkcontribs)

Thanks! You are faster fixing it, than I am writing you that there is something wrong :D

Hi, don't hesitate to add a topic if you want to ask/tell me something.

1
Ickputzdirwech (talkcontribs)

See the title :)

There are no older topics